-
Notifications
You must be signed in to change notification settings - Fork 585
Bypass find_package(torch) for find_package_torch_headers to help out cross compilation #8629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8629
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 71ef8af with merge base f3fc096 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
… cross compilation To be honest, I don't understand how the Android demo compiles currently. This should make it more robust, but I'm submitting this as a draft and will wait until I have a concrete need for this. ghstack-source-id: a984326 ghstack-comment-id: 2675755240 Pull Request resolved: #8629
error message I was getting for posterity:
|
ping reviewers @GregoryComer @dbort @kirklandsign |
Thank you @swolchok ! BTW this is macos only right? Sorry I didn't try on macos recently. |
not as far as I know, should be everything |
To be honest, I don't understand how the Android demo compiles currently. Indeed, it doesn't work on my Mac without this change, but with this change it does.
Should fix #8556