[Executorch][Optimized] Use portable's impl for optimized op_add's fallback #6737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llback This way we can get advantage of size and build opt efforts in portable kernels On one of the builds it saves X KB in app size when optimized lib is built with -Os Differential Revision: [D65666037](https://our.internmc.facebook.com/intern/diff/D65666037/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6737
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f2b0083 with merge base 39e5b91 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65666037 |
This was referenced Nov 8, 2024
…op_add's fallback" This way we can get advantage of size and build opt efforts in portable kernels On one of the builds it saves X KB in app size when optimized lib is built with -Os Differential Revision: [D65666037](https://our.internmc.facebook.com/intern/diff/D65666037/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65666037 |
kirklandsign
added
the
module: kernels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This way we can get advantage of size and build opt efforts in portable kernels
On one of the builds it saves X KB in app size when optimized lib is built
with -Os
Differential Revision: D65666037
cc @larryliu0820 @manuelcandales