[Exeuctorch][Optimized] Use portable path for fallback in op_mul #6733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove earlier copy paste from portable impl for fallack path. By relying directly on portable impl we can benefit from future optimizations in portable impl and avoid missing things like we did here. Differential Revision: [D65628858](https://our.internmc.facebook.com/intern/diff/D65628858/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6733
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d9c2e24 with merge base 39e5b91 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65628858 |
This was referenced Nov 8, 2024
…op_mul" Remove earlier copy paste from portable impl for fallack path. By relying directly on portable impl we can benefit from future optimizations in portable impl and avoid missing things like we did here. Differential Revision: [D65628858](https://our.internmc.facebook.com/intern/diff/D65628858/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65628858 |
metascroy
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Remove earlier copy paste from portable impl for fallack path. By relying
directly on portable impl we can benefit from future optimizations in portable
impl and avoid missing things like we did here.
Differential Revision: D65628858