[ET-VK][ez] properly parse skip memory metadata pass #6712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title. Currently, the compile option to skip memory metadata tagging is not being passed correctly to `vulkan_preprocess`. Differential Revision: [D65600049](https://our.internmc.facebook.com/intern/diff/D65600049/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6712
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 69e96f2 with merge base 545535b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
added a commit
that referenced
this pull request
Nov 7, 2024
As title. Currently, the compile option to skip memory metadata tagging is not being passed correctly to `vulkan_preprocess`. Differential Revision: [D65600049](https://our.internmc.facebook.com/intern/diff/D65600049/) ghstack-source-id: 252307280 Pull Request resolved: #6712
|
This pull request was exported from Phabricator. Differential Revision: D65600049 |
nathanaelsee
approved these changes
Nov 7, 2024
As title. Currently, the compile option to skip memory metadata tagging is not being passed correctly to `vulkan_preprocess`. Differential Revision: [D65600049](https://our.internmc.facebook.com/intern/diff/D65600049/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Nov 7, 2024
Pull Request resolved: #6712 As title. Currently, the compile option to skip memory metadata tagging is not being passed correctly to `vulkan_preprocess`. ghstack-source-id: 252359943 @exported-using-ghexport Differential Revision: [D65600049](https://our.internmc.facebook.com/intern/diff/D65600049/)
|
This pull request was exported from Phabricator. Differential Revision: D65600049 |
facebook-github-bot
merged commit 50e2121
into
gh/SS-JIA/139/base
39 of 41 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Nov 7, 2024
Pull Request resolved: #6712 As title. Currently, the compile option to skip memory metadata tagging is not being passed correctly to `vulkan_preprocess`. ghstack-source-id: 252359943 @exported-using-ghexport Differential Revision: [D65600049](https://our.internmc.facebook.com/intern/diff/D65600049/) Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As title. Currently, the compile option to skip memory metadata tagging is not being passed correctly to
vulkan_preprocess.Differential Revision: D65600049