Skip to content

Commit 69e96f2

Browse files
committed
Update on "[ET-VK][ez] properly parse skip memory metadata pass"
As title. Currently, the compile option to skip memory metadata tagging is not being passed correctly to `vulkan_preprocess`. Differential Revision: [D65600049](https://our.internmc.facebook.com/intern/diff/D65600049/) [ghstack-poisoned]
1 parent 9952ea2 commit 69e96f2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

backends/vulkan/partitioner/vulkan_partitioner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ def parse_compile_options(compile_options: Dict[str, Any]) -> List[CompileSpec]:
251251
if isinstance(value, (VkStorageType, VkMemoryLayout)):
252252
value_bytes = int(value).to_bytes(4, byteorder="little")
253253
compile_specs.append(CompileSpec(key, value_bytes))
254-
254+
255255
if isinstance(value, bool):
256256
value_bytes = value.to_bytes(1, byteorder="little")
257257
compile_specs.append(CompileSpec(key, value_bytes))

backends/vulkan/vulkan_preprocess.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def parse_compile_spec(compile_specs: List[CompileSpec]) -> Dict[str, Any]:
9898
)
9999
if spec.key in {"texture_limits_x", "texture_limits_y", "texture_limits_z"}:
100100
options[spec.key] = int.from_bytes(spec.value, byteorder="little")
101-
101+
102102
if spec.key == "skip_tag_memory_metadata":
103103
options[spec.key] = bool.from_bytes(spec.value, byteorder="little")
104104

0 commit comments

Comments
 (0)