Arm backend: Track target memory usage #5788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds memory stats API to a subclass of Memory Allocator and make it possible for the backend to track and report runtime memory usage. Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: I3570d689f4614d85e098c014717402fa6c619d9f
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5788
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 20b7716 with merge base 393553c ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
added
the
partner: arm
|
@pytorchbot label ciflow/trunk |
digantdesai
approved these changes
Oct 3, 2024
| @@ -135,6 +135,44 @@ void et_pal_emit_log_message( | |||
|
|
|||
| namespace { | |||
|
|
|||
| // Setup our own allocator that can show some extra stuff like used and free | |||
| // memory info | |||
| class ArmMemoryAllocator : public executorch::runtime::MemoryAllocator { | |||
Comment on lines
+163
to
+170
| size_t used_size() const { | ||
| return used_; | ||
| } | ||
|
|
||
| // Returns the free size of the allocator's memory buffer. | ||
| size_t free_size() const { | ||
| return executorch::runtime::MemoryAllocator::size() - used_; | ||
| } |
There was a problem hiding this comment.
can you add tests for these?
There was a problem hiding this comment.
As this is in our user example code I tried to keep it clean but it would be really nice to have some test on this code in some way Ill have it the back of my mind for maturing a bit.
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in b78ec1b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds memory stats API to a subclass of Memory Allocator and make it possible for the backend to track and report runtime memory usage.