Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm backend: Track target memory usage #5341

Closed
wants to merge 5 commits into from
Closed

Arm backend: Track target memory usage #5341

wants to merge 5 commits into from

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Sep 13, 2024

This adds memory stats API to the Memory Allocator and make it possible for the backends to track and report runtime memory usage.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5341

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 0f5f9d6 with merge base 3e79ea4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 13, 2024
@zingo
Copy link
Collaborator Author

zingo commented Sep 13, 2024

@pytorchbot label ciflow/trunk

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

rebase please?

@zingo
Arm backend: Track target memory usage
bb9910f 
This adds memory stats API to the Memory Allocator and make it
possible for the backends to track and report runtime memory usage.

Signed-off-by: Zingo Andersen <zingo.andersen@arm.com>
Change-Id: I73d3531f2430edaa91608a1b06dee4aedf79c5a3
@zingo zingo force-pushed the Arm-backend-Improve-memory-config-and-documentation-in-the-runtime branch from 49a0e61 to bb9910f Compare September 24, 2024 11:37
zingo and others added 4 commits September 24, 2024 13:57
@zingo
Arm backend: Improve memory config and documentation in the runtime
1bc1ee8 
Document the memory areas and make non semihosting memory areas
more configurable to make it more easy to build and test for
different setup/hardwares.

Signed-off-by: Zingo Andersen <zingo.andersen@arm.com>
Change-Id: I6a13c2e47f20e02ca79c7f8e20bfe2a3b0e41c94
@zingo
Revert "Arm backend: Improve memory config and documentation in the r…
ec2fce3 
…untime"

This reverts commit 1bc1ee8.
@zingo
Merge branch 'pytorch:main' into Arm-backend-Improve-memory-config-an…
005b43f 
…d-documentation-in-the-runtime
@zingo
Merge branch 'pytorch:main' into Arm-backend-Improve-memory-config-an…
0f5f9d6 
…d-documentation-in-the-runtime
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in e425dbb.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by d2ba238.

@mergennachin
Copy link
Contributor

Hi @zingo

I just reverted this PR. Can we not add additional virtual functions into the core memory allocator? It seems unnecessary...

And currently failed our binary size CI job.

@zingo
Copy link
Collaborator Author

zingo commented Sep 25, 2024 •
edited
Loading

@mergennachin
Oh sorry, no problem Ill get my number in some other way. Sorry for the breakage.

@zingo
Copy link
Collaborator Author

zingo commented Oct 1, 2024

Replaced by #5788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zingo @facebook-github-bot @digantdesai @mergennachin