[ET-VK][Op Redesign][6/n] Merge ArithmeticPrepack into PrepackNode #2261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a lot of shared logic between - `add_staging_to_tensor_node()`, which handles I/O data on execute(), and - `ArithmeticPrepack`'s simple prepacking, on prepack(). Both just copy data to and from GPU, without any manipulation. Hence, I've decided to consolidate shared logic in this diff as well. Here are the final results: + Make `PrepackNode` a final class. + Remove all references of `impl/Packing.h`. - Extract shared util functions to new `StagingUtils.h/cpp`. Differential Revision: [D54504449](https://our.internmc.facebook.com/intern/diff/D54504449/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2261
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ac9ebab with merge base 566209d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54504449 |
This was referenced Mar 5, 2024
SS-JIA
approved these changes
Mar 5, 2024
|
This pull request has been merged in 4a975ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
There's a lot of shared logic between
add_staging_to_tensor_node(), which handles I/O data on execute(), andArithmeticPrepack's simple prepacking, on prepack().Both just copy data to and from GPU, without any manipulation. Hence, I've decided to consolidate shared logic in this diff as well. Here are the final results:
PrepackNodea final class.impl/Packing.h.StagingUtils.h/cpp.Differential Revision: D54504449