[ET-VK][Op Redesign][4/n] Merge ArithmeticNode into ExecuteNode #2247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff moves the logic of `ArithmeticNode` into its corresponding OpFunction `add_arithmetic_node()` and the `ExecuteNode` class. Our aim is to remove all derived classes of `ExecuteNode`, i.e., to make `ExecuteNode` a final class. All operator-specific logic will be handled in the OpFunction. Note the next change will move `StagingNode` into its OpFunction + this new ExecuteNode implementation. Until then, we can't tidy up the `ExecuteNode` class fully. Finally, we leave a few task TODOs. Differential Revision: [D53982441](https://our.internmc.facebook.com/intern/diff/D53982441/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2247
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 7 PendingAs of commit df40507 with merge base 566209d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53982441 |
This was referenced Mar 4, 2024
jorgep31415
added a commit
that referenced
this pull request
Mar 4, 2024
This diff moves the logic of `ArithmeticNode` into its corresponding OpFunction `add_arithmetic_node()` and the `ExecuteNode` class. Our aim is to remove all derived classes of `ExecuteNode`, i.e., to make `ExecuteNode` a final class. All operator-specific logic will be handled in the OpFunction. Note the next change will move `StagingNode` into its OpFunction + this new ExecuteNode implementation. Until then, we can't tidy up the `ExecuteNode` class fully. Finally, we leave a few task TODOs. Differential Revision: [D53982441](https://our.internmc.facebook.com/intern/diff/D53982441/) ghstack-source-id: 217394061 Pull Request resolved: #2247
SS-JIA
approved these changes
Mar 4, 2024
…eNode" This diff moves the logic of `ArithmeticNode` into its corresponding OpFunction `add_arithmetic_node()` and the `ExecuteNode` class. Our aim is to remove all derived classes of `ExecuteNode`, i.e., to make `ExecuteNode` a final class. All operator-specific logic will be handled in the OpFunction. Note the next change will move `StagingNode` into its OpFunction + this new ExecuteNode implementation. Until then, we can't tidy up the `ExecuteNode` class fully. Finally, we leave a few task TODOs. Differential Revision: [D53982441](https://our.internmc.facebook.com/intern/diff/D53982441/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D53982441 |
jorgep31415
added a commit
that referenced
this pull request
Mar 5, 2024
Pull Request resolved: #2247 This diff moves the logic of `ArithmeticNode` into its corresponding OpFunction `add_arithmetic_node()` and the `ExecuteNode` class. Our aim is to remove all derived classes of `ExecuteNode`, i.e., to make `ExecuteNode` a final class. All operator-specific logic will be handled in the OpFunction. Note the next change will move `StagingNode` into its OpFunction + this new ExecuteNode implementation. Until then, we can't tidy up the `ExecuteNode` class fully. Finally, we leave a few task TODOs. ghstack-source-id: 217439330 @exported-using-ghexport Differential Revision: [D53982441](https://our.internmc.facebook.com/intern/diff/D53982441/)
This was referenced Mar 5, 2024
|
This pull request has been merged in 862f755. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff moves the logic of
ArithmeticNodeinto its corresponding OpFunctionadd_arithmetic_node()and theExecuteNodeclass.Our aim is to remove all derived classes of
ExecuteNode, i.e., to makeExecuteNodea final class. All operator-specific logic will be handled in the OpFunction.Note the next change will move
StagingNodeinto its OpFunction + this new ExecuteNode implementation. Until then, we can't tidy up theExecuteNodeclass fully. Finally, we leave a few task TODOs.Differential Revision: D53982441