NXP backend: NXP backend: Add option to run test reference quantized in Python#17733
Open
MartinPavella wants to merge 3 commits intopytorch:mainfrom
Conversation
MartinPavella
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17733
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 6b4e679 with merge base 331ac4a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@roman-janik-nxp please review this PR. There was some error and my previous PR is corrupted. The changes here should be identical to what you have approved in the other PR. |
Collaborator
Author
|
The corresponding Executorch Integration PR is here: https://bitbucket.sw.nxp.com/projects/AITEC/repos/executorch-integration/pull-requests/127/diff#test%2Fpython%2Ftests%2Ftest_mobilenet_v2.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NXP tests run models delegated to Neutron using the NSYS simulator. To determine correct output, a reference model is run on the CPU. Before, there were 2 choices for the reference, either non-delegated .pte file running in c++, or the original non-quantized float32 PyTorch model running in Python. This PR adds a 3rd option (to run in quantized edge dialect in Python), as well as easy extension to 2 more options in the future.
Test plan
Unit-tests provided.
cc @robert-kalmar @JakeStevens @digantdesai