Skip to content

NXP backend: Add option to run test reference quantized in Python#17619

Closed
MartinPavella wants to merge 0 commit intopytorch:mainfrom
nxp-upstream:nxg01483/EIEX-740-add-option-to-run-test-reference-quantized-in-python
Closed

NXP backend: Add option to run test reference quantized in Python#17619
MartinPavella wants to merge 0 commit intopytorch:mainfrom
nxp-upstream:nxg01483/EIEX-740-add-option-to-run-test-reference-quantized-in-python

Conversation

@MartinPavella
Copy link
Collaborator

@MartinPavella MartinPavella commented Feb 23, 2026

Summary

NXP tests run models delegated to Neutron using the NSYS simulator. To determine correct output, a reference model is run on the CPU. Before, there were 2 choices for the reference, either non-delegated .pte file running in c++, or the original non-quantized float32 PyTorch model running in Python. This PR adds a 3rd option (to run in quantized edge dialect in Python), as well as easy extension to 2 more options in the future.

Test plan

Unit-tests provided.

cc @robert-kalmar @JakeStevens @digantdesai

@MartinPavella MartinPavella added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Feb 23, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17619

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 7103948 with merge base ef6ceae (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2026
@MartinPavella
Copy link
Collaborator Author

@StrycekSimon feel free to review and use this functionality in your PR.

@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-740-add-option-to-run-test-reference-quantized-in-python branch from 62afe26 to 087e0a0 Compare February 23, 2026 14:49
@MartinPavella
Copy link
Collaborator Author

MartinPavella commented Feb 23, 2026

@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-740-add-option-to-run-test-reference-quantized-in-python branch from 087e0a0 to 7103948 Compare February 23, 2026 15:12
Copy link
Collaborator

@StrycekSimon StrycekSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me. 👍

@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-740-add-option-to-run-test-reference-quantized-in-python branch from 7103948 to 331ac4a Compare February 26, 2026 10:59
@MartinPavella
Copy link
Collaborator Author

@roman-janik-nxp I have no idea what happened, but when I re-based onto main, this PR got some sort of a failure, it closed automatically, and I cannot re-open it nor does it show the 3 commits ahead of main. So I have created a new PR with exactly the same commits you have just approved (#17733). I would appreciate an approval there so I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants