NXP backend: Add support for aten.max_pool1d.default.#17706
Open
MartinPavella wants to merge 5 commits intopytorch:mainfrom
Open
NXP backend: Add support for aten.max_pool1d.default.#17706MartinPavella wants to merge 5 commits intopytorch:mainfrom
aten.max_pool1d.default.#17706MartinPavella wants to merge 5 commits intopytorch:mainfrom
Conversation
MartinPavella
requested review from
StrycekSimon,
jirioc and
roman-janik-nxp
MartinPavella
requested review from
mergennachin and
robert-kalmar
as code owners
MartinPavella
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17706
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 32c0d66 with merge base 331ac4a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@novak-vaclav please feel free to review as well. |
Collaborator
Author
|
This PR is based on #17412 as they are closely related. Feel free to review that one first. |
MartinPavella
force-pushed
the
nxg01483/EIEX-732-add-support-for-aten.max_pool1d-to-nxp-backend
branch
from
9aa24f9 to
2db295c
Compare
novak-vaclav
suggested changes
Feb 26, 2026
backends/nxp/tests/ir/converter/node_converter/test_max_pool_2d_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_max_pool_2d_converter.py
Show resolved
Hide resolved
This change is in preparation for `aten.max_pool1d.default` support, which gets converted to unsqueeze -> max_pool2d_with_indices -> squeeze during lowering to edge. So the `max_pool2d_with_indices` must be converted to `max_pool2d` in edge dialect.
MartinPavella
force-pushed
the
nxg01483/EIEX-732-add-support-for-aten.max_pool1d-to-nxp-backend
branch
from
2db295c to
32c0d66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reworks
max_pool2dsupport to accurately reflect Neutron requirements, and adds support formax_pool1dvia shape extension to 4D and leveraging existingmax_pool2dsupport.Test plan
Unit-tests provided.
cc @robert-kalmar @JakeStevens @digantdesai