NXP backend: Add support for aten.avg_pool1d.default.#17412
Open
MartinPavella wants to merge 1 commit intopytorch:mainfrom
Open
NXP backend: Add support for aten.avg_pool1d.default.#17412MartinPavella wants to merge 1 commit intopytorch:mainfrom
aten.avg_pool1d.default.#17412MartinPavella wants to merge 1 commit intopytorch:mainfrom
Conversation
MartinPavella
requested review from
mergennachin and
robert-kalmar
as code owners
MartinPavella
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17412
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 8b2200a with merge base 331ac4a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
The changes are based on another PR (#16540) so only the last commit is relevant. |
MartinPavella
force-pushed
the
nxg01483/EIEX-705-add-support-for-aten.avg_pool1d-to-nxp-backend
branch
from
7984709 to
ce9a9ed
Compare
Collaborator
Author
|
@novak-vaclav can you please take a look at this PR? |
Contributor
|
Looks good to me 👍 |
MartinPavella
force-pushed
the
nxg01483/EIEX-705-add-support-for-aten.avg_pool1d-to-nxp-backend
branch
2 times, most recently
from
4d3a51e to
1bed0ab
Compare
MartinPavella
force-pushed
the
nxg01483/EIEX-705-add-support-for-aten.avg_pool1d-to-nxp-backend
branch
from
1bed0ab to
42b7291
Compare
backends/nxp/edge_passes/move_auxiliary_operator_into_separate_qdq_cluster_pass.py
Outdated
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_avg_pool2d_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_avg_pool2d_converter.py
Show resolved
Hide resolved
backends/nxp/tests/ir/converter/node_converter/test_avg_pool2d_converter.py
Show resolved
Hide resolved
MartinPavella
force-pushed
the
nxg01483/EIEX-705-add-support-for-aten.avg_pool1d-to-nxp-backend
branch
from
42b7291 to
8b2200a
Compare
Contributor
|
Thank you for incorporating my comments into the code @MartinPavella |
novak-vaclav
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the conversion from aten dialect to edge dialect, ExecuTorch replaces the
avg_pool1dwithavg_pool_2dand adds anaten,unsqueezebefore, to introduce the 4th dimension of size 1, and anaten.squeezeis added after to remove it. Theavg_pool1dis then supported by the existingAvgPool2DConverter.Test plan
Unit-tests provided.
cc @robert-kalmar @JakeStevens @digantdesai