Skip to content

Conversation

@ayushrajdahal
Copy link

Summary

Implement ConvertBatchNormToDepthwiseConvPass to handle standalone batch normalization operations that cannot be fused with preceding convolutions.

Fixes #11586

Key changes:

  • New pass converts standalone BatchNorm to equivalent 1x1 depthwise convolutions
  • Updated BatchNormConfig to support both fusable and standalone batch norms
  • Added pass to XNNPACKPassManager before existing fusion pass
  • Updated tests to expect successful partitioning of standalone batch norms

Uses mathematical equivalence:
conv_weight = bn_weight / sqrt(bn_var + eps)
conv_bias = bn_bias - bn_mean * conv_weight

Test plan

# test fused batch norm
python -m pytest backends/xnnpack/test/passes/test_batch_norm_fusion.py -v

# for standalone batch norm
python -m pytest backends/xnnpack/test/passes/test_batch_norm_to_depthwise_conv.py -v

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11844

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3a62512 with merge base daebcde (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@keyprocedure
Copy link
Contributor

Hi @penknife6153, I worked on the linear fused batchnorm PR and noticed some overlap between our work. Let me know if I can help with anything!

@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 13, 2025
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Standalone Batch Norm

3 participants