Skip to content

Add visibility to codegen's gen_lib so users can use it #11386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Jun 4, 2025

Summary: This allows them to use executorch.codegen.gen

Differential Revision: D75996100

@larryliu0820 larryliu0820 requested a review from lucylq as a code owner June 4, 2025 23:16
Copy link

pytorch-bot bot commented Jun 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11386

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e423027 with merge base 36a3207 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75996100

@larryliu0820 larryliu0820 added the release notes: none Do not include this in the release notes label Jun 4, 2025
@larryliu0820 larryliu0820 changed the title Migrate Jarvis away from torchgen.gen_executorch Add visibility to codegen's gen_lib so users can use it Jun 4, 2025
facebook-github-bot pushed a commit that referenced this pull request Jun 4, 2025
Summary:

and instead use executorch.codegen.gen

Reviewed By: mcremon-meta

Differential Revision: D75996100
larryliu0820 added a commit that referenced this pull request Jun 4, 2025
Summary:

and instead use executorch.codegen.gen

Reviewed By: mcremon-meta

Differential Revision: D75996100
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75996100

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75996100

larryliu0820 added a commit that referenced this pull request Jun 4, 2025
Summary:
Pull Request resolved: #11386

and instead use executorch.codegen.gen

Reviewed By: mcremon-meta

Differential Revision: D75996100
larryliu0820 added a commit that referenced this pull request Jun 5, 2025
Summary:

and instead use executorch.codegen.gen

Reviewed By: mcremon-meta

Differential Revision: D75996100
Summary:
Pull Request resolved: #11386

and instead use executorch.codegen.gen

Reviewed By: mcremon-meta

Differential Revision: D75996100
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75996100

@facebook-github-bot facebook-github-bot merged commit b2c02fe into main Jun 5, 2025
96 of 98 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D75996100 branch June 5, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants