Skip to content

fix Swift compiler assert (#10874) #10875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

rmaz
Copy link
Contributor

@rmaz rmaz commented May 14, 2025

Summary:

Asserts toolchains are crashing on compiling this header:

(struct_type decl="ObjectiveC.(file).ObjCBool")
(type_alias_type decl="ExecuTorch.(file).BoolValue@/ExecuTorch/ExecuTorchValue.h:37:14"
  (underlying=struct_type decl="Swift.(file).Bool"))
swift-frontend: swift/lib/ClangImporter/ImportType.cpp:928: ImportResult (anonymous namespace)::SwiftTypeConverter::VisitTypedefType(const clang::TypedefType *): Assertion `underlyingResult.AbstractType->isEqual(mappedType) && "typedef without special typedef kind was mapped " "differently from its underlying type?"' failed.

Remove NS_SWIFT_BRIDGED_TYPEDEF to mitigate.

Reviewed By: shoumikhin, AdamCmiel

Differential Revision: D74737507

Summary:

Asserts toolchains are crashing on compiling this header:
```
(struct_type decl="ObjectiveC.(file).ObjCBool")
(type_alias_type decl="ExecuTorch.(file).BoolValue@/ExecuTorch/ExecuTorchValue.h:37:14"
  (underlying=struct_type decl="Swift.(file).Bool"))
swift-frontend: swift/lib/ClangImporter/ImportType.cpp:928: ImportResult (anonymous namespace)::SwiftTypeConverter::VisitTypedefType(const clang::TypedefType *): Assertion `underlyingResult.AbstractType->isEqual(mappedType) && "typedef without special typedef kind was mapped " "differently from its underlying type?"' failed.
```
Remove `NS_SWIFT_BRIDGED_TYPEDEF` to mitigate.

Reviewed By: shoumikhin, AdamCmiel

Differential Revision: D74737507
@rmaz rmaz requested a review from shoumikhin as a code owner May 14, 2025 17:33
Copy link

pytorch-bot bot commented May 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10875

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 10 Pending, 2 Unrelated Failures

As of commit 2a1563e with merge base 12b5eb6 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74737507

@facebook-github-bot facebook-github-bot merged commit f39e694 into pytorch:main May 14, 2025
80 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants