Skip to content

fix Swift compiler assert #10874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shoumikhin
Copy link
Contributor

Summary:
Asserts toolchains are crashing on compiling this header:

(struct_type decl="ObjectiveC.(file).ObjCBool")
(type_alias_type decl="ExecuTorch.(file).BoolValue@buck-out/v2/gen/fbsource/b60f3548330a4950/xplat/executorch/extension/apple/__ExecuTorch__/ExecuTorch_symlink_tree/ExecuTorch/ExecuTorchValue.h:37:14"
  (underlying=struct_type decl="Swift.(file).Bool"))
swift-frontend: /data/sandcastle/boxes/trunk-grepo-llvm-c2-grepo/external/swift/lib/ClangImporter/ImportType.cpp:928: ImportResult (anonymous namespace)::SwiftTypeConverter::VisitTypedefType(const clang::TypedefType *): Assertion `underlyingResult.AbstractType->isEqual(mappedType) && "typedef without special typedef kind was mapped " "differently from its underlying type?"' failed.

Remove NS_SWIFT_BRIDGED_TYPEDEF to mitigate.

Differential Revision: D74737507

Summary:
Asserts toolchains are crashing on compiling this header:
```
(struct_type decl="ObjectiveC.(file).ObjCBool")
(type_alias_type decl="ExecuTorch.(file).BoolValue@buck-out/v2/gen/fbsource/b60f3548330a4950/xplat/executorch/extension/apple/__ExecuTorch__/ExecuTorch_symlink_tree/ExecuTorch/ExecuTorchValue.h:37:14"
  (underlying=struct_type decl="Swift.(file).Bool"))
swift-frontend: /data/sandcastle/boxes/trunk-grepo-llvm-c2-grepo/external/swift/lib/ClangImporter/ImportType.cpp:928: ImportResult (anonymous namespace)::SwiftTypeConverter::VisitTypedefType(const clang::TypedefType *): Assertion `underlyingResult.AbstractType->isEqual(mappedType) && "typedef without special typedef kind was mapped " "differently from its underlying type?"' failed.
```
Remove `NS_SWIFT_BRIDGED_TYPEDEF` to mitigate.

Differential Revision: D74737507
Copy link

pytorch-bot bot commented May 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10874

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures, 1 Cancelled Job, 7 Unrelated Failures

As of commit c073797 with merge base e1738cc (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74737507

@shoumikhin
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 14, 2025
facebook-github-bot pushed a commit that referenced this pull request May 14, 2025
Differential Revision: D74737507

Pull Request resolved: #10875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants