-
Notifications
You must be signed in to change notification settings - Fork 557
fix Swift compiler assert #10874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shoumikhin
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
shoumikhin:export-D74737507
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix Swift compiler assert #10874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Asserts toolchains are crashing on compiling this header: ``` (struct_type decl="ObjectiveC.(file).ObjCBool") (type_alias_type decl="ExecuTorch.(file).BoolValue@buck-out/v2/gen/fbsource/b60f3548330a4950/xplat/executorch/extension/apple/__ExecuTorch__/ExecuTorch_symlink_tree/ExecuTorch/ExecuTorchValue.h:37:14" (underlying=struct_type decl="Swift.(file).Bool")) swift-frontend: /data/sandcastle/boxes/trunk-grepo-llvm-c2-grepo/external/swift/lib/ClangImporter/ImportType.cpp:928: ImportResult (anonymous namespace)::SwiftTypeConverter::VisitTypedefType(const clang::TypedefType *): Assertion `underlyingResult.AbstractType->isEqual(mappedType) && "typedef without special typedef kind was mapped " "differently from its underlying type?"' failed. ``` Remove `NS_SWIFT_BRIDGED_TYPEDEF` to mitigate. Differential Revision: D74737507
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10874
Note: Links to docs will display an error until the docs builds have been completed. ❌ 19 New Failures, 1 Cancelled Job, 7 Unrelated FailuresAs of commit c073797 with merge base e1738cc ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D74737507 |
@pytorchbot label "release notes: none" |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2025
Differential Revision: D74737507 Pull Request resolved: #10875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
release notes: none
Do not include this in the release notes
topic: not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Asserts toolchains are crashing on compiling this header:
Remove
NS_SWIFT_BRIDGED_TYPEDEF
to mitigate.Differential Revision: D74737507