migrate nf4 to configs #1857
Merged
migrate nf4 to configs #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1857
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 7, 2025
vkuzo
added a commit
that referenced
this pull request
Mar 7, 2025
Summary: 1. migrate nf4 to configs 2. create a separate, temporary, workflow file for nf4 to get around circular import errors. A future person should properly make nf4 a workflow in torchao's dir structure, but that is out of scope for this PR. Test Plan: ``` pytest test/dtypes/test_nf4.py ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 160d039 ghstack-comment-id: 2707042209 Pull Request resolved: #1857
vkuzo
added
the
topic: not user facing
vkuzo
added a commit
that referenced
this pull request
Mar 7, 2025
Summary: 1. migrate nf4 to configs 2. create a separate, temporary, workflow file for nf4 to get around circular import errors. A future person should properly make nf4 a workflow in torchao's dir structure, but that is out of scope for this PR. Test Plan: ``` pytest test/dtypes/test_nf4.py ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f9960e5 ghstack-comment-id: 2707042209 Pull Request resolved: #1857
This was referenced Mar 7, 2025
andrewor14
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
circular import errors. A future person should properly make nf4 a
workflow in torchao's dir structure, but that is out of scope for
this PR.
Note that this technically breaks "BC", but nf4 isn't an official API so there isn't really BC. This does not break the torchtune integration.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: