Skip to content

migrate prototype/quantized_training to configs #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Mar 12, 2025
Merged

migrate prototype/quantized_training to configs #1855

merged 36 commits into from
Mar 12, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 7, 2025

Summary:

As titled

Test Plan:

pytest test/prototype/test_quantized_training.py -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 5 commits March 7, 2025 06:48
@vkuzo
Update
73ea701 
[ghstack-poisoned]
@vkuzo
Update
4f2c69d 
[ghstack-poisoned]
@vkuzo
Update
75fb698 
[ghstack-poisoned]
@vkuzo
Update
5796efc 
[ghstack-poisoned]
@vkuzo
Update
3b016e7 
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 7, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1855

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit db3e3d3 with merge base 8c81863 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vkuzo vkuzo mentioned this pull request Mar 7, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
This was referenced Mar 7, 2025
Merged
Merged
Merged
vkuzo added a commit that referenced this pull request Mar 7, 2025
@vkuzo
migrate prototype/quantized_training to configs
913a9e9 
Summary:

As titled

Test Plan:

```
pytest test/prototype/test_quantized_training.py -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e4b9e86
ghstack-comment-id: 2706898680
Pull Request resolved: #1855
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 7, 2025

cc @gau-nernst as a heads up

@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 7, 2025
@vkuzo
Update
11bce08 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 7, 2025
@vkuzo
migrate prototype/quantized_training to configs
f75da99 
Summary:

As titled

Test Plan:

```
pytest test/prototype/test_quantized_training.py -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 764c20e
ghstack-comment-id: 2706898680
Pull Request resolved: #1855
This was referenced Mar 7, 2025
Closed
Merged
Merged
vkuzo added 3 commits March 7, 2025 09:51
@vkuzo
Update
125546b 
[ghstack-poisoned]
@vkuzo
Update
130a52e 
[ghstack-poisoned]
@vkuzo
Update
70e0e53 
[ghstack-poisoned]
@vkuzo vkuzo mentioned this pull request Mar 7, 2025
Merged
vkuzo added 6 commits March 7, 2025 11:39
@vkuzo
Update
cf3ad33 
[ghstack-poisoned]
@vkuzo
Update
19ac99d 
[ghstack-poisoned]
@vkuzo
Update
5deed22 
[ghstack-poisoned]
@vkuzo
Update
2a1f7b2 
[ghstack-poisoned]
@vkuzo
Update
5fa0e27 
[ghstack-poisoned]
@vkuzo
Update
0ecb02d 
[ghstack-poisoned]
vkuzo added 4 commits March 7, 2025 12:47
@vkuzo
Update
7cb810c 
[ghstack-poisoned]
@vkuzo
Update
eb567cd 
[ghstack-poisoned]
@vkuzo
Update
cd97b30 
[ghstack-poisoned]
@vkuzo
Update
de38b6e 
[ghstack-poisoned]
drisspg
drisspg reviewed Mar 7, 2025
View reviewed changes
torchao/prototype/quantized_training/bitnet.py


# for bc
bitnet_training = BitNetTrainingConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on bc break here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually prefer to keep it, see previous PR for some additional context

vkuzo added 15 commits March 8, 2025 06:15
@vkuzo
Update
6f3d127 
[ghstack-poisoned]
@vkuzo
Update
cda5d18 
[ghstack-poisoned]
@vkuzo
Update
96d74a3 
[ghstack-poisoned]
@vkuzo
Update
c83c029 
[ghstack-poisoned]
@vkuzo
Update
6f1c92d 
[ghstack-poisoned]
@vkuzo
Update
fdb292e 
[ghstack-poisoned]
@vkuzo
Update
706ff1f 
[ghstack-poisoned]
@vkuzo
Update
ac2314e 
[ghstack-poisoned]
@vkuzo
Update
8002c39 
[ghstack-poisoned]
@vkuzo
Update
0506d32 
[ghstack-poisoned]
@vkuzo
Update
237a72a 
[ghstack-poisoned]
@vkuzo
Update
10d0dff 
[ghstack-poisoned]
@vkuzo
Update
2ec7827 
[ghstack-poisoned]
@vkuzo
Update
fa8c0f1 
[ghstack-poisoned]
@vkuzo
Update
8c8d7e4 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/58/head to main March 8, 2025 20:19
@vkuzo vkuzo mentioned this pull request Mar 10, 2025
Merged
@vkuzo
Update
c038451 
[ghstack-poisoned]
@vkuzo vkuzo mentioned this pull request Mar 10, 2025
Merged
@vkuzo
Update
db3e3d3 
[ghstack-poisoned]
@vkuzo vkuzo merged commit c04106c into main Mar 12, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg left review comments

@andrewor14 andrewor14 andrewor14 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkuzo @andrewor14 @drisspg @facebook-github-bot