-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp development workflow #622
Revamp development workflow #622
Conversation
We can re-add it at a later date if needed.
This seems to be for training a model for spam detection, but this file isn't referenced in the codebase.
This should reduce our install times
I'm gonna assume that everyone is OK to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put in some comments.
Otherwise, LGTM!
directories: | ||
- $HOME/.pip-cache/ | ||
language: python | ||
python: 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for choosing 3.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works -- every other version seems to have some issue with the outdated-and-pinned dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Okay. Will keep a note to update this in future if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now!
@pradyunsg One nit though, can we keep the Dockerfile and docker-compose.yml for now and explicitly mark them as deprecated? |
We can come back later to fix them. |
I'm going to go ahead and merge this in, since it unblocks our CI (when Travis isn't acting up), there's a green tick, and only a nit pointed out after. re Docker: I prefer keeping things in master that are "known working" -- since it is at the back of a whole bunch of folks' minds (and a tracking issue exists) for working on the Docker setup, it definitely won't hurt to remove these outright now (when they're not working) and add a working variant later. If anyone wants to add back the not-working Dockerfile later, we can do it in another PR too (I won't block that in any way, even though I think that would be as not-useful as having a broken Dockerfile in master). |
nox