Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp development workflow #622

Merged
merged 9 commits into from
Mar 10, 2020
Merged

Revamp development workflow #622

merged 9 commits into from
Mar 10, 2020

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Mar 10, 2020

  • Cleanup unnecessary files from the root of the repository
  • Move to using nox
  • Significantly update Travis CI configuration

We can re-add it at a later date if needed.
This seems to be for training a model for spam detection, but this file
isn't referenced in the codebase.
@pradyunsg pradyunsg mentioned this pull request Mar 10, 2020
@pradyunsg pradyunsg marked this pull request as ready for review March 10, 2020 12:52
@pradyunsg
Copy link
Contributor Author

I'm gonna assume that everyone is OK to add nox (used for automation in https://github.com/pypa/packaging/, https://github.com/pypa/pip/ and more) and to revamp our CI to... well, actually work. All my follow up PRs will be based off this, just to make my own life easier. :)

Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in some comments.

Otherwise, LGTM!

.travis.yml Outdated Show resolved Hide resolved
directories:
- $HOME/.pip-cache/
language: python
python: 3.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for choosing 3.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works -- every other version seems to have some issue with the outdated-and-pinned dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Okay. Will keep a note to update this in future if needed.

Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now!

@palnabarun
Copy link
Member

@pradyunsg One nit though, can we keep the Dockerfile and docker-compose.yml for now and explicitly mark them as deprecated?

@palnabarun
Copy link
Member

We can come back later to fix them.

@pradyunsg
Copy link
Contributor Author

I'm going to go ahead and merge this in, since it unblocks our CI (when Travis isn't acting up), there's a green tick, and only a nit pointed out after.

re Docker: I prefer keeping things in master that are "known working" -- since it is at the back of a whole bunch of folks' minds (and a tracking issue exists) for working on the Docker setup, it definitely won't hurt to remove these outright now (when they're not working) and add a working variant later. If anyone wants to add back the not-working Dockerfile later, we can do it in another PR too (I won't block that in any way, even though I think that would be as not-useful as having a broken Dockerfile in master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants