Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline failing for flake8 #613

Closed
onlinejudge95 opened this issue Oct 5, 2019 · 2 comments
Closed

Pipeline failing for flake8 #613

onlinejudge95 opened this issue Oct 5, 2019 · 2 comments

Comments

@onlinejudge95
Copy link

Hi Guys,

I created a PR on my fork of this repo. While merging changes from pythonindia/junction to my fork the travis build is failing for all 3 versions of Python, with the following traceback.

$ flake8
/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/flake8/engine.py:33: PkgResourcesDeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.
  checker = entry.load(require=False)
/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/django/contrib/webdesign/__init__.py:11: RemovedInDjango110Warning: django.contrib.webdesign will be removed in Django 1.10. The {% lorem %} tag is now included in the built-in tags.
  RemovedInDjango110Warning
./junction/proposals/views.py:296:5: E303 too many blank lines (2)
Monkey patching...
/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/django_markdown/urls.py:8: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  '', url('preview/$', preview, name='django_markdown_preview'))
System check identified some issues:
WARNINGS:
?: (1_8.W001) The standalone TEMPLATE_* settings were deprecated in Django 1.8 and the TEMPLATES dictionary takes precedence. You must put the values of the following settings into your default TEMPLATES dict: TEMPLATE_DEBUG.
 
 -------------- celery@travis-job-9adbea46-f7f4-4aa2-a7d3-0f3005734c49 v3.1.20 (Cipater)
---- **** ----- 
--- * ***  * -- Linux-4.15.0-1028-gcp-x86_64-with-debian-stretch-sid
-- * - **** --- 
- ** ---------- [config]
- ** ---------- .> app:         junction:0x7f9e3d0b2198
- ** ---------- .> transport:   redis://localhost:6379/0
- ** ---------- .> results:     redis://localhost:6379/0
- *** --- * --- .> concurrency: 2 (prefork)
-- ******* ---- 
--- ***** ----- [queues]
 -------------- .> tasks            exchange=tasks(topic) key=task.#
                .> transient        exchange=tasks(topic) key=transient.#
[tasks]
  . junction.conferences.tasks.add
  . junction.proposals.services.send_mail_for_new_comment
  . junction.proposals.services.send_mail_for_new_proposal
  . junction.proposals.services.send_mail_for_proposal_content
The command "flake8" exited with 1.

Travis Build link :- https://travis-ci.com/onlinejudge95/junction/jobs/242362724
Build Log (plaintext) :- https://api.travis-ci.com/v3/job/242362724/log.txt

@ananyo2012
Copy link
Contributor

@palnabarun #622 fixes this. Ran flake8 using nox -e lint and it passes now.

@palnabarun
Copy link
Member

@ananyo2012 Thanks for checking this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants