Skip to content

Fix RGBA typing for UIInputText's caret_color #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 13, 2024

TL;DR: Use the RGBA caret color in pyglet back in #1744

Other things took priority at the time. Working on #2062 reminded me to take care of this.

Changes

  1. Fix type annotation, default argument, and docstring
  2. Remove unused import

@pushfoo
Copy link
Member Author

pushfoo commented Apr 13, 2024

The CI failures are the pyright issues which #2062 fixes.

@Cleptomania Cleptomania merged commit 2671261 into pythonarcade:development Apr 13, 2024
7 of 8 checks passed
@pushfoo pushfoo deleted the fix_rgba_for_carets branch April 13, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants