-
Notifications
You must be signed in to change notification settings - Fork 343
Eliminate pyright errors #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate pyright errors #2062
Conversation
Thanks for the contribution. @pushfoo Is this ready to merge? For me it looks fine, the new functionality within Rect seems to be useful and the AsFloat makes the usage of values clear. |
TL;DR: Give it a look over on Mac and Windows for the text scrolling text and text drawing examples? I just went through those examples under Linux. It looks fine here as far as a quick glance can tell. @DigiDuncan @DragonMoffon could you two help out look at those examples under Windows? Also, I think Eruvanos has a mac. Btw, scale changes are actually somewhat conservative. I'm considering more in the future but the current one seemed small enough to merge now. |
TL;DR: Non-
#type: ignore
fixes for GUI type issues through annotations + int conversionWhy
float
conversion of their labels & layouts, we need to account for it:int
behavior / storage for layoutsfloat
storageChanges
AsFloat = Union[float, int
type to:arcade.gui.Rect
arcade.gui.Rect.scale
behaviorrounding=None
behavior toarcade.gui.Rect.scale
+ testsint
conversion shims to stop pyright issues2.1dev*
release.pyi
useful to reduce#type: ignore
cruftTest steps taken