Skip to content

UIDummy clarity improvements #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2023
Merged

UIDummy clarity improvements #1757

merged 4 commits into from
May 7, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented May 7, 2023 •
edited
Loading

Changes

tl;dr minor clarity improvements discovered during work on a follow-up to #1750

  1. Clean up UIDummy top-level docstring
  2. Fix a PyCharm linter highlight by adding UIDummy to an __all__ list
  3. Use Color.random(a=255) instead of inlined RGB tuple generation

How to test

  1. python -m arcade.gui.examples.box_layout
  2. Make sure UIDummy instances still change colors when clicked
  3. Make sure UIDummy instances still print their rect values to the terminal when clicked

Follow-ups

I'll be submitting another PR containing docstring fixes for the GUI examples later.

@pvcraven pvcraven merged commit 1378a25 into pythonarcade:development May 7, 2023
@pushfoo pushfoo deleted the uidummy_touchups branch May 7, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @pvcraven