Skip to content

UIDummy clarity improvements #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2023
Merged

UIDummy clarity improvements #1757

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7956552
Clarify UIDummy docstring
pushfoo May 7, 2023
b383636
Replace RGB color generation with equivalent Color.random(a=255) call
pushfoo May 7, 2023
eee08e2
Fix PyCharm lint warning by adding UIDummy to __all__
pushfoo May 7, 2023
88fb699
Phrasing tweak in UIDummy docstring
pushfoo May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions arcade/gui/widgets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
from arcade.gui.nine_patch import NinePatchTexture
from arcade.gui.property import Property, bind, ListProperty
from arcade.gui.surface import Surface
from arcade.types import RGBA255
from arcade.types import RGBA255, Color

if TYPE_CHECKING:
from arcade.gui.ui_manager import UIManager

__all__ = ["Surface"]
__all__ = ["Surface", "UIDummy"]


class Rect(NamedTuple):
Expand Down Expand Up @@ -716,8 +716,14 @@ def on_click(self, event: UIOnClickEvent):

class UIDummy(UIInteractiveWidget):
"""
Solid color widget, used for testing.
Prints own rect on click.
Solid color widget used for testing & examples

It should not be subclassed for real-world usage.

When clicked, it does the following:

* Outputs its `rect` attribute to the console
* Changes its color to a random fully opaque color

:param float x: x coordinate of bottom left
:param float y: y coordinate of bottom left
Expand Down Expand Up @@ -759,7 +765,7 @@ def __init__(

def on_click(self, event: UIOnClickEvent):
print("UIDummy.rect:", self.rect)
self.color = (randint(0, 255), randint(0, 255), randint(0, 255))
self.color = Color.random(a=255)

def on_update(self, dt):
self.border_width = 2 if self.hovered else 0
Expand Down