Replace brittle os.chdir usage in make.py with a context manager #1726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks onto #1725.
Changes
cd
behaviorrun
to accept an optionalcd
pathrun_doc
function combiningrun
with a constantos.chdir
os.chdir('../')
in command functionsThis doesn't use a combined decorator function because typer interacts poorly with other decorators.
How to test
The important parts should be covered by this, run as a script or individually.