Fix build script location output#1725
Merged
Cleptomania merged 4 commits intoApr 25, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
make.pytells you where the output files are relative to the build script, like it used toAlso ty to @tiffanyxiao for some really nice PR formatting (#1721, #1723)! I may adopt aspects of it going forward.
How to test
cdinto the project rootpython make.py htmlWhy
tl;dr less confusing to beginners
The behavior on
developmentis currently not user friendly as it literally copies theMakefilesyntax:Since we have a 1:1 port of the
Makefile, we may as well go the full mile in restoring home directory templating too. It might be useful to have in git history as boilerplate for someone later.