Skip to content

Fix whitespace linting + backlog of whitespace issues #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 19, 2023
Merged

Fix whitespace linting + backlog of whitespace issues #1706

merged 10 commits into from
Apr 19, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 19, 2023

tl;dr

  1. Closes CI doesn't pick up multiple whitespace style issues #1701
  2. Switching to ruff broke linting in since it's not actually a drop-in replacement
  3. Adding "W" to the select list in [tool.ruff] re-enables whitepsace linting

We should merge this PR quickly because:

  1. It can affect PyCon mentored sprint participants
  2. It has already been affecting junior contributors (see Clean _check_for_collision #1702 (comment)).
  3. Whitespace issues have been accumulating since February when we switched to ruff (1a3e993)

@pushfoo pushfoo changed the title Fix whitespace linter config + backlog of whitespace issues Fix whitespace linting + backlog of whitespace issues Apr 19, 2023
@Cleptomania Cleptomania merged commit 96f3638 into pythonarcade:development Apr 19, 2023
@pushfoo pushfoo mentioned this pull request Apr 20, 2023
Merged
@pushfoo pushfoo deleted the re_enable_linting branch May 7, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI doesn't pick up multiple whitespace style issues
2 participants
@pushfoo @Cleptomania