Skip to content

Fix spacing issues to get this branch rolling again #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 20, 2023

Conversation

pushfoo
Copy link

@pushfoo pushfoo commented Apr 20, 2023

tl;dr merge this PR into your branch and it'll automatically update your PR addressing __all__ (pythonarcade#1681)

  1. Whitespace linting was broken in arcade for months. Sorry about that, I know it created some headaches.
  2. I fixed it in Fix whitespace linting + backlog of whitespace issues pythonarcade/arcade#1706, and running ruff should now work for any branch up to date with development
  3. I fixed up your PR directly to spare you the hassle of back and forth reviews since it's not fair for beginners to expect them to deal with broken tooling.

ruff --fix path/to/file/ should now auto-fix many classes of reported issues. Also, you will still get credit for the final squashed commit in arcade's git history.

pushfoo added 9 commits April 19, 2023 17:27
)

* Re-enable whitespace linting by fixing ruff config

* Fix trailing whitespace & trailing whitespace in arcade/*.py

* Fix whitespace linting in arcade/experimental

* Fix whitespace in arcade/texture

* Fix whitespace in arcade/texture_atlas

* Fix whitespace in arcade/gui

* Fix whitespace in arcade/sprite_list

* Fix whitespace in arcade/gl

* Fix whitespace in arcade/examples

* Fix whitespace in arcade/resources
@pushfoo pushfoo changed the title Fix annoying spacing issues to get this branch rolling again Fix spacing issues to get this branch rolling again Apr 20, 2023
@gran4 gran4 self-requested a review April 20, 2023 16:23
Copy link
Owner

@gran4 gran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one thing

@@ -147,9 +147,9 @@ def __init__(self):

example_text = dedent(
"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove indent

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your doing a PR into my fork. How does that work? I'm new to open source contributing so I don't know what I'm doing with this lol.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pushfoo how do I merge this into my thing?
When I try it says: "merge: pushfoo-pushfoo_add__all__to_all - not something we can merge"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try it says: "merge: pushfoo-pushfoo_add__all__to_all - not something we can merge"

I found a way to do that, but scene might not be in there

@gran4
Copy link
Owner

gran4 commented Apr 20, 2023

Thanks a lot. I was stuck

@gran4 gran4 merged commit 484bbf1 into gran4:add__all__to_all Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants