-
Notifications
You must be signed in to change notification settings - Fork 0
Fix spacing issues to get this branch rolling again #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spacing issues to get this branch rolling again #1
Conversation
) * Re-enable whitespace linting by fixing ruff config * Fix trailing whitespace & trailing whitespace in arcade/*.py * Fix whitespace linting in arcade/experimental * Fix whitespace in arcade/texture * Fix whitespace in arcade/texture_atlas * Fix whitespace in arcade/gui * Fix whitespace in arcade/sprite_list * Fix whitespace in arcade/gl * Fix whitespace in arcade/examples * Fix whitespace in arcade/resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that one thing
@@ -147,9 +147,9 @@ def __init__(self): | |||
|
|||
example_text = dedent( | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, your doing a PR into my fork. How does that work? I'm new to open source contributing so I don't know what I'm doing with this lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pushfoo how do I merge this into my thing?
When I try it says: "merge: pushfoo-pushfoo_add__all__to_all - not something we can merge"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try it says: "merge: pushfoo-pushfoo_add__all__to_all - not something we can merge"
I found a way to do that, but scene might not be in there
Thanks a lot. I was stuck |
tl;dr merge this PR into your branch and it'll automatically update your PR addressing
__all__
(pythonarcade#1681)ruff
should now work for any branch up to date with developmentruff --fix path/to/file/
should now auto-fix many classes of reported issues. Also, you will still get credit for the final squashed commit in arcade's git history.