Fix get_type_hints() on x-module inherited TypedDict in 3.9 and 3.10#94
Merged
JelleZijlstra merged 6 commits intopython:mainfrom Nov 12, 2022
Merged
Fix get_type_hints() on x-module inherited TypedDict in 3.9 and 3.10#94JelleZijlstra merged 6 commits intopython:mainfrom
JelleZijlstra merged 6 commits intopython:mainfrom
Conversation
AlexWaygood
reviewed
Nov 11, 2022
JelleZijlstra
approved these changes
Nov 11, 2022
This was referenced Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in python/cpython#27017 was never backported into typing-extensions.
In 3.11 it doesn't matter because we just use
TypedDictfromtyping.py. But in 3.9 and 3.10, it means this cross-module inheritance scenario with stringified annotations andget_type_hintswill fail if you useTypedDictfromtyping_extensionsbut work if you use it fromtyping.I don't attempt here to backport the fix to pre-3.9 versions where
typing.pydoesn't have it; that would require pulling in lots more code (ForwardRefand some utility functions) intotyping_extensions.py. Just aiming for parity withtyping.pyfor 3.9 and 3.10.