fix: Interaction with get_type_hints and Annotated <3.11.#312
Draft
DanCardin wants to merge 1 commit intopython:mainfrom
Draft
fix: Interaction with get_type_hints and Annotated <3.11.#312DanCardin wants to merge 1 commit intopython:mainfrom
DanCardin wants to merge 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
All commit authors signed the Contributor License Agreement. |
Contributor
|
I think this has been superseded by #482? |
Contributor
I think so as well. Its a possible reference in case more needs to be pulled back at some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I now see why #94 opted to avoid copying the whole function 😮💨
Fixes #310.
Although its unclear to me whether/how fully replicating
ForwardRefmight have downstream effects on things. Certainly it seems like anyone usingisinstance(x, ForwardRef)will not work after this below 3.11, but the original class is also Final, so I wasn't sure what else to do about it.