-
-
Notifications
You must be signed in to change notification settings - Fork 124
Add some miscellaneous tests #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thank you!
The Python 3.10+ implementation started raising in PR#165
Thanks for the review! I pushed a few changes. re: making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making ParamSpec.init_subclass raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in #165, which didn't include a changelog entry.
Imo, it's worth noting. That it is now consistent with the other versions.
Probably worth it, just to be safe? I feel like #165 probably should have had a changelog mention too if it changed behaviour 😄 |
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Daraan <github.blurry@9ox.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think there's a merge conflict
Add tests to exercise some previously unexercised lines:
_SpecialGenericAlias.__setattr__()
for non-dunder, non-"allowed" attributes (src)_SpecialGenericAlias
from without defaults (src)_SpecialGenericAlias
with 0 type parameters (src)<thing>.__module__
on Python implementations that don't supplysys._getframemodulename
orsys._getframe
(src)get_type_hints()
withtypes.GenericAlias
(src)__init_subclass__()
ofParamSpec
(src)__or__()
and__ror__()
of_SpecialForm
(src)__repr__
and__reduce__
ofNoExtraItems
(test case copied fromNoDefaultTests
) (src)