Bring over TypeVarTests from CPython#165
Merged
JelleZijlstra merged 2 commits intopython:mainfrom May 21, 2023
Merged
Conversation
I started out trying to backport python/cpython#104571, but realized that it makes sense to backport CPython's whole TypeVarTests class since we now have our own implementation of TypeVar. I dropped test_var_substitution and test_bad_var_substitution since they rely on the internal __typing_subst__ method, and the type substitution logic is generally very hard to get precisely the same across versions.
Member
Author
|
CI is failing because we didn't bring over the fix for python/cpython#84123. It doesn't seem worth the effort to fix that for early versions of 3.7 and 3.8, so I'm just going to skip that test before 3.9. |
AlexWaygood
approved these changes
May 21, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Haven't done a line-by-line review, but I trust in your copy-and-paste abilities :)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started out trying to backport python/cpython#104571, but
realized that it makes sense to backport CPython's whole TypeVarTests
class since we now have our own implementation of TypeVar.
I dropped test_var_substitution and test_bad_var_substitution
since they rely on the internal typing_subst method, and the
type substitution logic is generally very hard to get precisely
the same across versions.