Skip to content

Third-party stubs: fix several fictitious type aliases #7958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2022

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 26, 2022

Fixes #7954

I also did some driveby TypeAlias fixes.

@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member Author

AlexWaygood commented May 26, 2022

Not sure why stubtest is failing to import google-cloud-ndb. Seems like it was able to import it just fine last night: https://github.com/python/typeshed/runs/6602180879?check_suite_focus=true

@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member Author

For some reason, it looks like stubtest for this PR is installing a different version of protobuf than the one it did for the daily test last night.


Last night
protobuf==3.20.1 was installed for testing google-cloud-ndb

This PR
protobuf==4.21.0 is being installed for testing google-cloud-ndb


I've no idea if that's what's causing the CI failure here, or why a different version of protobuf is being installed now.

@AlexWaygood
Copy link
Member Author

AlexWaygood commented May 26, 2022

For some reason, it looks like stubtest for this PR is installing a different version of protobuf than the one it did for the daily test last night.

Last night protobuf==3.20.1 was installed for testing google-cloud-ndb

This PR protobuf==4.21.0 is being installed for testing google-cloud-ndb

I've no idea if that's what's causing the CI failure here, or why a different version of protobuf is being installed now.

Manually pinning the version of protobuf that stubtest installs for google-cloud-ndb seems to have fixed it, so I guess this was the problem.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
Copy link
Member

Note that protobuf 4.21.0 was just released yesterday: https://pypi.org/project/protobuf/#history

@JelleZijlstra JelleZijlstra merged commit fa636bc into python:master May 26, 2022
@AlexWaygood
Copy link
Member Author

Note that protobuf 4.21.0 was just released yesterday: https://pypi.org/project/protobuf/#history

Ahh, makes sense. I was searching through the google-cloud-ndb source code for changes, and couldn't see anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stubtest failed on Thu May 26 2022
2 participants