Skip to content

[google-cloud-ndb] Remove unncessary stubtest requirements #13631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

[google-cloud-ndb] Remove unncessary stubtest requirements #13631

merged 1 commit into from
Mar 16, 2025

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Mar 16, 2025

Closes: #13444

@srittau srittau changed the title [google-clouid-ndb] Remove unncessary stubtest requirements [google-cloud-ndb] Remove unncessary stubtest requirements Mar 16, 2025
@srittau
Copy link
Collaborator Author

srittau commented Mar 16, 2025

Better: https://github.com/python/typeshed/actions/runs/13883229491/job/38844529834?pr=13631

AlexWaygood
AlexWaygood approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tracking this down! Do we know why we added these in the first place?

@srittau
Copy link
Collaborator Author

srittau commented Mar 16, 2025

six was added by a certain @AlexWaygood in #10704 to fix #10703. This was fixed upstream in googleapis/python-ndb#912. six was apparently removed in version 2.3.1.

protobuf was added by that same mysterious person in #7958 (in @tests/requirements-stubtest.txt), who wrote back in 2022:

For some reason, it looks like stubtest for this PR is installing a different version of protobuf than the one it did for the daily test last night.

That problem seems to have been fixed since then.

@srittau srittau merged commit 02aee8d into python:main Mar 16, 2025
38 checks passed
@srittau srittau deleted the gcn-rm-reqs branch March 16, 2025 14:34
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
@srittau
[google-cloud-ndb] Remove unncessary stubtest requirements (python#13631
fde9b68 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One shard on the daily test workflow is taking 20 minutes to complete
2 participants
@srittau @AlexWaygood