Skip to content

Add new constants to winsound #13695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2025
Merged

Add new constants to winsound #13695

merged 5 commits into from
May 18, 2025

Conversation

aisk
Copy link
Contributor

@aisk aisk commented Mar 21, 2025

They were introduced in: python/cpython#131454 and will be available in 3.14.

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Mar 21, 2025

Thank you for your contribution. Unfortunately, we only accept PRs to the standard lib for future Python versions after the first beta has been released. Please feel free to ping us after this has happened and if this PR is still relevant.

@srittau srittau closed this Mar 21, 2025
@Avasam
Copy link
Collaborator

Avasam commented May 15, 2025

@aisk Beta 1 has been released! I don't think contributors can re-open their PRs. You can let us know if you'd like us to re-open this or you can create a new PR!

@aisk
Copy link
Contributor Author

aisk commented May 16, 2025

Hi thank you for review and noticing! I checked that in current main branch (and also 3.14 beta 1), this change is still validate: https://github.com/python/cpython/blob/main/PC/winsound.c#L238-L250 so please re-open this PR, thanks!

@srittau srittau reopened this May 16, 2025

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented May 16, 2025

Thanks, you need to remove the winsound entries from stdlib/@tests/stubtest_allowlists/win32-py314.txt now.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 43ea05d into python:main May 18, 2025
64 checks passed
@aisk aisk deleted the sync-winsound branch May 19, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants