-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-131453: Add missing constants to winsound module #131454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM. Any other changes coming here, or is this ready to merge? |
All usable constants are added in this PR, so it's ready to merge. |
|
||
.. data:: MB_ICONWARNING | ||
|
||
Play the ``SystemExclamation`` sound. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these could all use a ..versionadded:: next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added!
FWIW, the |
SND_ALIAS_ID
has not been added towinsound
in this PR because it requires passing thehmod
parameter to thePlaySound
function. Since we do not expose this parameter, it does not make sense to addSND_ALIAS_ID
before we support thehmod
parameter.Other possible macrons are added.
winsound
module. #131453📚 Documentation preview 📚: https://cpython-previews--131454.org.readthedocs.build/