Skip to content

Run regen-configure script if available #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

sethmlarson
Copy link
Collaborator

Closes #83 @Yhg1s was this the fix you were imagining?

@Yhg1s
Copy link
Member

Yhg1s commented Jan 19, 2024

I guess this could work, but it's not what I had in mind, no. I had in mind just running the steps needed to regen configure:

     subprocess.check_call(
        [db["git_repo"] / "Tools/build/regen-configure.sh"],
     )

... but that will only work for 3.12 and later. 3.10 and 3.11 still require the use of podman/docker and Christian's images. We could backport the regen-configure script to those releases and make it then run docker the way the makefile currently does, I guess. (@pablogsal for that idea). I don't think we want to make 3.10/3.11 use autoconf 2.71 instead of the modified 2.69 from Christian's images at this point.

@sethmlarson
Copy link
Collaborator Author

@Yhg1s That makes sense, I'll move forward with backporting that script instead.

@sethmlarson
Copy link
Collaborator Author

@Yhg1s I've changed course on this since updating the builds of 3.11 and prior was closed, instead now we look for the regen-configure.sh script and fallback to the prior implementation using Docker. Let me know what you think.

@sethmlarson sethmlarson force-pushed the make-regen-configure-fix branch from 73ebbed to cacde86 Compare February 5, 2024 22:32
@sethmlarson sethmlarson changed the title Run './configure' before 'make regen-configure' Run regen-configure script if available Feb 6, 2024
@sethmlarson sethmlarson requested a review from Yhg1s February 6, 2024 13:54
@Yhg1s Yhg1s merged commit 38ce4f4 into python:master Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with make regen-configure
2 participants