[3.11] gh-112160: Backport 'Tools/build/regen-configure.sh' script #114333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
added
needs backport to 3.8
needs backport to 3.9
sethmlarson
changed the title
|
@pablogsal Fixed this one up to be passing all checks, should be ready now :) |
|
Discussed this with other RMs and we might need to go a different direction if the build for 3.10 and earlier can't be modified. Will propose a change in python/release-tools instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #112160, it turns out to be advantageous to have the actual script outside of the Makefile so it can be called without calling
./configurefirst, as is the case in release-tools.This would need to be backported from 3.11 to 3.8 so release-tools can work for all versions.
regen-configuretarget to supported branches #112160