Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fuzzies in library/unittest.po #1004

Merged
merged 6 commits into from
Dec 15, 2019

Conversation

Seluj78
Copy link
Collaborator

@Seluj78 Seluj78 commented Nov 17, 2019

Oui je sais j'ai mis une virgule et un point à la ligne 2427 mais c'est déjà dans les tuyaux !

python/cpython#17211

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Nov 17, 2019
@Seluj78 Seluj78 self-assigned this Nov 17, 2019
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padpo donne plein de warnings pour ce fichier, je t'ai remonté les remarques sur les parties que tu as modifiées.

Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est padpo ! (je m'en lasse pas de cette blague pourrie 😉)

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Dec 13, 2019

Done @vpoulailleau @christopheNan

@Seluj78 Seluj78 removed the NEED REVIEWER This PR needs a reviewer :) label Dec 13, 2019
christopheNan
christopheNan previously approved these changes Dec 14, 2019
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste un adjectif à accorder et c'est bon pour moi.

Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Dec 14, 2019

@christopheNan vu que j'ai commit ta suggestion il me faut une nouvelle approbation

@christopheNan christopheNan merged commit 1a8eaca into python:3.8 Dec 15, 2019
@Seluj78 Seluj78 deleted the fuzzies-unittest branch December 15, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants