Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing comma and period in unittest docs #17211

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Add missing comma and period in unittest docs #17211

merged 2 commits into from
Nov 19, 2019

Conversation

Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Nov 17, 2019 •
edited by miss-islington
Loading

Automerge-Triggered-By: @csabella

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 17, 2019
@Seluj78 Seluj78 mentioned this pull request Nov 17, 2019
Merged
@Seluj78
Copy link
Contributor Author

Seluj78 commented Nov 18, 2019

@csabella what is the automerge waiting for ? 😄

@taleinat
Copy link
Contributor

@Seluj78, the automerge is waiting for a core-dev to approve this PR.

@taleinat taleinat changed the title Added missing coma in unittest.rst Add missing comma and period in unittest docs Nov 18, 2019
@miss-islington miss-islington merged commit b1f160a into python:master Nov 19, 2019
@miss-islington
Copy link
Contributor

Thanks @Seluj78 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2019
@Seluj78 @miss-islington
Add missing comma and period in unittest docs (pythonGH-17211)
ba4a4a8 
Automerge-Triggered-By: @csabella
(cherry picked from commit b1f160a)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@bedevere-bot
Copy link

GH-17256 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @Seluj78, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b1f160a236cb590b1c1a678ca5fc19d5c75dcd83 3.7

@miss-islington miss-islington self-assigned this Nov 19, 2019
miss-islington added a commit that referenced this pull request Nov 19, 2019
@miss-islington @Seluj78
Add missing comma and period in unittest docs (GH-17211)
c749326 
Automerge-Triggered-By: @csabella
(cherry picked from commit b1f160a)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
Seluj78 added a commit to Seluj78/cpython that referenced this pull request Nov 19, 2019
@Seluj78
[3.7] Add missing comma and period in unittest docs (pythonGH-17211)
49e4d34 
Automerge-Triggered-By: @csabella.
(cherry picked from commit b1f160a)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@bedevere-bot
Copy link

GH-17259 is a backport of this pull request to the 3.7 branch.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@Seluj78
Add missing comma and period in unittest docs (pythonGH-17211)
27ebcf1 
Automerge-Triggered-By: @csabella
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Seluj78 @shihai1991
Add missing comma and period in unittest docs (pythonGH-17211)
0a0dbe4 
Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Seluj78 @taleinat @miss-islington @bedevere-bot @csabella @brandtbucher @the-knights-who-say-ni