Move code of handling TypedDict __getitem__ to plugins #11683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Dec 9, 2021
| @@ -2981,8 +2981,8 @@ def visit_index_with_type(self, left_type: Type, e: IndexExpr, | |||
| return make_simplified_union(out) | |||
| else: | |||
| return self.nonliteral_tuple_index_helper(left_type, index) | |||
| elif isinstance(left_type, TypedDictType): | |||
| return self.visit_typeddict_index_expr(left_type, e.index) | |||
| # elif isinstance(left_type, TypedDictType): | |||
There was a problem hiding this comment.
Yeah it's a rollback. Do you have opinions about the original proposal #6138? It that case maybe we should alse move delitem and setitem to plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6138
infer_literal_expr_type()Test Plan