Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to handle Tuple and TypedDict __getitem__ to plugins #6138

Open
Michael0x2a opened this issue Jan 4, 2019 · 1 comment
Open

Move code to handle Tuple and TypedDict __getitem__ to plugins #6138

Michael0x2a opened this issue Jan 4, 2019 · 1 comment
Assignees

Comments

@Michael0x2a
Copy link
Collaborator

Currently, we handle calls to both Tuple and TypedDict's __getitem__ code inside checkexpr. We should consider turning some or all of this code into a plugin.

I think it's somewhat debatable how useful this refactor would be for Tuple's __getitem__, but it would at least make the way we handle TypedDicts more consistent: we currently handle all other TypedDict methods inside of a plugin.

Also see #6124 (comment) for context.

@Michael0x2a Michael0x2a added refactoring Changing mypy's internals priority-2-low labels Jan 4, 2019
@Michael0x2a Michael0x2a self-assigned this Jan 4, 2019
@ilevkivskyi
Copy link
Member

Note that it is better to fix #6117 first to avoid making it even more problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants