Merged
Conversation
…ld markers that are no longer needed
emmatyping
commented
Jul 22, 2021
| virtualenv>=20.6.0 | ||
| setuptools!=50 | ||
| importlib-metadata==0.20 | ||
| importlib-metadata>=4.6.1,<5.0.0 |
Member
Author
There was a problem hiding this comment.
The very old version of this was causing a failure with the new virtualenv.
hauntsaninja
approved these changes
Jul 22, 2021
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This works around a change in virtualenv 20.x where the site-packages folder is added to the
PYTHONPATHvariable. We detect if the python executable is in a virtualenv by comparing the prefix and base prefix, and ignoring the issue if the site-package folder is under the virtualenv prefix.This is an alternative to #10846
Fixes #10407