Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI on Python 3.10 #11297

Merged
merged 9 commits into from
Oct 11, 2021
Merged

Conversation

97littleleaf11
Copy link
Collaborator

Description

Closes #11294

Test Plan

Check the tests still failed.

Comment on lines 107 to 108
if: ${{ matrix.python == '3.10' }}
run: pip install --upgrade virtualenv==20.4.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to just use virtualenv 20 always instead of just on python 3.10. #10855 seems to have added support for using virtualenv 20, so I think that PR just forgot to update the CI to use virtualenv 20.

@TH3CHARLie
Copy link
Collaborator

TH3CHARLie commented Oct 8, 2021

You may need to fix the build by fixing mypyc imports first

@97littleleaf11
Copy link
Collaborator Author

We could probably merge #11017 first

@JelleZijlstra
Copy link
Member

We could probably merge #11017 first

Done!

@hauntsaninja
Copy link
Collaborator

Hooray!

@hauntsaninja
Copy link
Collaborator

Can we merge master for #11306

from distutils.core import setup
from setuptools import setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the usage of distutils that is causing a DeprecationWarning is in the setup.py mypyc generates to build C extensions:

mypy/scripts/mypyc

Lines 21 to 28 in 8cba3bc

setup_format = """\
from distutils.core import setup
from mypyc.build import mypycify
setup(name='mypyc_output',
ext_modules=mypycify({}, opt_level="{}"),
)
"""

I'm not really sure what this file's for but I don't think this is what's causing the CI failure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm looking at these. However I just wondering whether should I modify the test-data/packages/typedpkg-stubs/setup.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a sample package used for unit tests. We should probably update it too, but it should only affect a few unit tests.

@97littleleaf11
Copy link
Collaborator Author

Passes all tests now

Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on making Python 3.10 working in CI

@JelleZijlstra JelleZijlstra merged commit 332b712 into python:master Oct 11, 2021
@97littleleaf11 97littleleaf11 deleted the python3-10 branch October 11, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI to use Python 3.10
5 participants