Skip to content

Clarify that PyUnstable macros use "PyUnstable" prefix #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 1, 2023

@vstinner
Copy link
Member Author

vstinner commented Sep 1, 2023

My previous abandoned PR for the Python documentation (Doc/c-api/stable.rst): python/cpython#108710

cc @encukou

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable clarification and guidance to me.

@willingc
Copy link
Collaborator

@vstinner I'm going to merge. If @encukou has a different viewpoint, we can always go back and modify. Thanks Victor.

@willingc willingc merged commit fd1c58f into python:main Sep 29, 2023
@vstinner vstinner deleted the pyunstable branch September 29, 2023 19:43
@vstinner
Copy link
Member Author

You're welcome Carol.

@encukou
Copy link
Member

encukou commented Oct 2, 2023

Sorry, I dropped the ball here. Thank you Carol for picking it up!

A technicality: I wouldn't call macros symbols -- it's better to reserve that term to the stuff that's exported from a .so/DLL.

But with the list of examples, it's fine.

@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2023

A technicality: I wouldn't call macros symbols -- it's better to reserve that term to the stuff that's exported from a .so/DLL.

Maybe names is a better term here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants