Skip to content

gh-93951: In test_bdb.StateTestCase.test_skip, avoid including auxiliary importers. #93962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 2 commits into from
Jun 22, 2022
Merged

gh-93951: In test_bdb.StateTestCase.test_skip, avoid including auxiliary importers. #93962

ambv merged 2 commits into from
Jun 22, 2022

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Jun 17, 2022 •
edited
Loading

Fixes gh-93951

@jaraco jaraco changed the title bpo-93951: In test_bdb.StateTestCase.test_skip, avoid including auxiliary importers. gh-93951: In test_bdb.StateTestCase.test_skip, avoid including auxiliary importers. Jun 17, 2022
@jaraco jaraco force-pushed the gh-93951/test-bdb-meta-path-sensitivity branch from df5bcf2 to d36b0dd Compare June 17, 2022 19:21
@jaraco jaraco mentioned this pull request Jun 17, 2022
Closed
@jaraco jaraco force-pushed the gh-93951/test-bdb-meta-path-sensitivity branch from d36b0dd to 27d86b9 Compare June 18, 2022 00:21
brettcannon
brettcannon approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One PEP 8 violation, but otherwise LGTM!

@jaraco @brettcannon
Update Lib/test/support/__init__.py
8c1b431 
Co-authored-by: Brett Cannon <brett@python.org>
@tiran
Copy link
Member

tiran commented Jun 22, 2022

Why is the new helper method needed? The case looks like a job for https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch

@ambv
Copy link
Contributor

ambv commented Jun 22, 2022

@serhiy-storchaka points out that the new patch_list helper preserves identity of the patched list which might be an important property for some use cases. In particular, looks like sys.meta_path manipulation in tests always preserves the list's identity. Let's keep this then.

@ambv ambv merged commit c029b55 into main Jun 22, 2022
@ambv ambv deleted the gh-93951/test-bdb-meta-path-sensitivity branch June 22, 2022 12:05
@miss-islington
Copy link
Contributor

miss-islington commented Jun 22, 2022

Thanks @jaraco for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 22, 2022

GH-94118 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Jun 22, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jun 22, 2022

GH-94119 is a backport of this pull request to the 3.10 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_bdb is sensitive to sys.meta_path manipulation

7 participants

@jaraco @tiran @ambv @miss-islington @bedevere-bot @brettcannon