bpo-34399: 2048 bits RSA keys and DH params #8762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: 2.7 and 3.6 need additional fixes from GH-5247 |
nmav
reviewed
Aug 14, 2018
Lib/test/dh2048.pem
Outdated
| 82:1e:06:47:02:7f:ac:fc:8b:5f:1a:14:c3:c0:ee: | ||
| 28:81:d1:48:7d:78:f0:17:dc:c8:aa:ae:07:b7:39: | ||
| 56:cb | ||
| generator: 2 (0x2) |
There was a problem hiding this comment.
one improvement towards future-compatibility could be to use standardized DH prime parameters e.g., from rfc7919. Thinking of future implementation change which could verify that the primes used come from a known set params.
tiran
force-pushed
the
bpo34399-key2048bits
branch
from
4d1f20e to
6ffe200
Compare
|
@nmav I have updated the DH test file to use RFC 7919 high FFDH parameters with 3072 bits. |
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Finite field DH param file use RFC 7919 values, generated with
certtool --get-dh-params --sec-param=high
Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo34399-key2048bits
branch
from
6ffe200 to
b46f02e
Compare
|
@tiran: Please replace |
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-8763 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @tiran, I could not cleanly backport this to |
|
Sorry, @tiran, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 14, 2018
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Finite field DH param file use RFC 7919 values, generated with
certtool --get-dh-params --sec-param=high
Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 88bfd0b)
Co-authored-by: Christian Heimes <christian@python.org>
|
GH-8764 is a backport of this pull request to the 3.6 branch. |
|
GH-8765 is a backport of this pull request to the 2.7 branch. |
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Aug 14, 2018
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Finite field DH param file use RFC 7919 values, generated with
certtool --get-dh-params --sec-param=high
Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 88bfd0b)
Co-authored-by: Christian Heimes <christian@python.org>
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Aug 14, 2018
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Finite field DH param file use RFC 7919 values, generated with
certtool --get-dh-params --sec-param=high
Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 88bfd0b)
Co-authored-by: Christian Heimes <christian@python.org>
tiran
added a commit
that referenced
this pull request
Aug 14, 2018
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Finite field DH param file use RFC 7919 values, generated with
certtool --get-dh-params --sec-param=high
Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 88bfd0b)
Co-authored-by: Christian Heimes <christian@python.org>
tiran
added a commit
that referenced
this pull request
Aug 14, 2018
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Finite field DH param file use RFC 7919 values, generated with
certtool --get-dh-params --sec-param=high
Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 88bfd0b)
Co-authored-by: Christian Heimes <christian@python.org>
tiran
added a commit
that referenced
this pull request
Aug 15, 2018
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Finite field DH param file use RFC 7919 values, generated with
certtool --get-dh-params --sec-param=high
Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 88bfd0b)
Co-authored-by: Christian Heimes <christian@python.org>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Aug 19, 2018
* master: (107 commits) bpo-22057: Clarify eval() documentation (pythonGH-8812) bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623) bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741) bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811) bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808) bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797) Improve error message when mock.assert_has_calls fails (pythonGH-8205) Warn not to set SIGPIPE to SIG_DFL (python#6773) bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796) bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793) bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787) bpo-34217: Use lowercase for windows headers (pythonGH-8472) bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756) bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775) bpo-34384: Fix os.readlink() on Windows (pythonGH-8740) closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439) bpo-34399: 2048 bits RSA keys and DH params (python#8762) Make regular expressions in test_tasks.py raw strings. (pythonGH-8759) smtplib documentation fixes (pythonGH-8708) Fix misindented yaml in logging how to example (pythonGH-8604) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream vendors have started to deprecate weak keys. Update all RSA keys
and DH params to use at least 2048 bits.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue34399