Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misindented yaml example #8604

Merged
merged 1 commit into from
Aug 12, 2018
Merged

Misindented yaml example #8604

merged 1 commit into from
Aug 12, 2018

Conversation

Natim
Copy link
Contributor

@Natim Natim commented Aug 1, 2018

While reading the howto, I've seen that the logger config for root was misindented.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Aug 1, 2018
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@Natim
Copy link
Contributor Author

Natim commented Aug 1, 2018 •
edited
Loading

https://bugs.python.org/user?@template=clacheck&github_names=natim should be ok in about one business day.

@Mariatta
Copy link
Member

Mariatta commented Aug 9, 2018

Thanks. It seems like your CLA is still not received yet after several days.

@Natim
Copy link
Contributor Author

Natim commented Aug 9, 2018

Mariatta do you have an email where I can transfer you the CLA?
It has been sent by echosign@echosign.com to ewa@python.org on August 1st 2018 at 10:51 CET

@Mariatta
Copy link
Member

Mariatta commented Aug 9, 2018

You can write to contributors@python.org and ask about the status.

@Mariatta Mariatta merged commit 10b59f1 into python:master Aug 12, 2018
@miss-islington
Copy link
Contributor

Thanks @Natim for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2018
@Natim @miss-islington
Fix misindented yaml in logging how to example (pythonGH-8604)
c59cb25 
(cherry picked from commit 10b59f1)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
@Mariatta
Copy link
Member

Thanks and congrats on your first contribution to CPython 🌮

@bedevere-bot
Copy link

GH-8751 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8752 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2018
@Natim @miss-islington
Fix misindented yaml in logging how to example (pythonGH-8604)
44474bf 
(cherry picked from commit 10b59f1)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
miss-islington added a commit that referenced this pull request Aug 13, 2018
@miss-islington @Natim
Fix misindented yaml in logging how to example (GH-8604)
393151e 
(cherry picked from commit 10b59f1)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
miss-islington added a commit that referenced this pull request Aug 13, 2018
@miss-islington @Natim
Fix misindented yaml in logging how to example (GH-8604)
4cd33cd 
(cherry picked from commit 10b59f1)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Aug 19, 2018
@carljm
Merge branch 'master' into cached-property
977ece0 
* master: (107 commits)
  bpo-22057: Clarify eval() documentation (pythonGH-8812)
  bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623)
  bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741)
  bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811)
  bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808)
  bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797)
  Improve error message when mock.assert_has_calls fails (pythonGH-8205)
  Warn not to set SIGPIPE to SIG_DFL (python#6773)
  bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796)
  bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793)
  bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787)
  bpo-34217: Use lowercase for windows headers (pythonGH-8472)
  bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756)
  bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775)
  bpo-34384: Fix os.readlink() on Windows (pythonGH-8740)
  closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439)
  bpo-34399: 2048 bits RSA keys and DH params (python#8762)
  Make regular expressions in test_tasks.py raw strings. (pythonGH-8759)
  smtplib documentation fixes (pythonGH-8708)
  Fix misindented yaml in logging how to example (pythonGH-8604)
  ...
@Natim Natim deleted the patch-2 branch September 6, 2018 12:11
@Natim
Copy link
Contributor Author

Natim commented Sep 6, 2018 •
edited
Loading

I just realized while reading https://docs.python.org/3/howto/logging-cookbook.html?highlight=dictconfig#a-more-elaborate-multiprocessing-example that my fix was actually a mistake :/

Natim pushed a commit to Natim/cpython that referenced this pull request Sep 6, 2018
Revert "Fix misindented yaml in logging how to example (pythonGH-8604)"
d532d57 
This reverts commit 10b59f1.
@Natim Natim mentioned this pull request Sep 6, 2018
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2018
@Natim @miss-islington
Revert "Fix misindented yaml in logging how to example (pythonGH-8604)…
4fa4653 
…" (pythonGH-9081)

This reverts commit 10b59f1.
(cherry picked from commit 290a60b)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2018
@Natim @miss-islington
Revert "Fix misindented yaml in logging how to example (pythonGH-8604)…
d2616fa 
…" (pythonGH-9081)

This reverts commit 10b59f1.
(cherry picked from commit 290a60b)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
zhangyangyu pushed a commit that referenced this pull request Sep 10, 2018
@Natim @zhangyangyu
Revert "Fix misindented yaml in logging how to example (GH-8604)" (GH…
290a60b 
…-9081)

This reverts commit 10b59f1.
miss-islington added a commit that referenced this pull request Sep 10, 2018
@miss-islington @Natim
Revert "Fix misindented yaml in logging how to example (GH-8604)" (GH…
9c9ac9e 
…-9081)

This reverts commit 10b59f1.
(cherry picked from commit 290a60b)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
miss-islington added a commit that referenced this pull request Sep 10, 2018
@miss-islington @Natim
Revert "Fix misindented yaml in logging how to example (GH-8604)" (GH…
8eda821 
…-9081)

This reverts commit 10b59f1.
(cherry picked from commit 290a60b)

Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Natim @the-knights-who-say-ni @Mariatta @miss-islington @bedevere-bot