Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] bpo-31676: Fix test_imp.test_load_source() side effect (GH-3871) #3988

Merged
merged 1 commit into from
Oct 18, 2017
Merged

[3.6] bpo-31676: Fix test_imp.test_load_source() side effect (GH-3871) #3988

merged 1 commit into from
Oct 18, 2017

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 13, 2017 •
edited by bedevere-bot
Loading

test_load_source() now replaces the current name module with a
temporary module to prevent side effects.
(cherry picked from commit a505ecd)

https://bugs.python.org/issue31676

@vstinner @miss-islington
[3.6] bpo-31676: Fix test_imp.test_load_source() side effect (pythonG…
29e9e80 
…H-3871)

test_load_source() now replaces the current __name__ module with a
temporary module to prevent side effects.
(cherry picked from commit a505ecd)
@bedevere-bot bedevere-bot mentioned this pull request Oct 13, 2017
Merged
vstinner
vstinner approved these changes Oct 13, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@Haypo: Backport status check is done, and it's a success ✅ .

@Mariatta Mariatta merged commit 1781480 into python:3.6 Oct 18, 2017
@miss-islington
Copy link
Contributor Author

Thanks, @Mariatta!

@miss-islington miss-islington deleted the backport-a505ecd-3.6 branch October 18, 2017 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot